Use Iota Types for sinner contract_type #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes introduce a code generation directive for the Changes
TipsChat with CodeRabbit Bot (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/sinner #1498 +/- ##
=====================================================
- Coverage 50.97978% 50.90552% -0.07426%
=====================================================
Files 369 369
Lines 25465 25455 -10
Branches 268 268
=====================================================
- Hits 12982 12958 -24
- Misses 11215 11222 +7
- Partials 1268 1275 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- services/sinner/config/indexer/config.go (1 hunks)
- services/sinner/config/indexer/contracttype_string.go (2 hunks)
Files skipped from review due to trivial changes (2)
- services/sinner/config/indexer/config.go
- services/sinner/config/indexer/contracttype_string.go
nautsimon
approved these changes
Oct 25, 2023
nautsimon
added a commit
that referenced
this pull request
Nov 2, 2023
* init * stashing at prev checkpoint to resolve build issues * updating graphql * live filling updates * stash prev changes before tests * update queries w/tests * update api and cli * stash before deploy * api tests * lint * lint * lint + gen * code cov * gen * adding code cov * lint + test + coderabbit suggestions * symlink * edits * hold * Update go.mod * sinner docker + main.go * sinner test flake, bytes -> hex string update, update assert use, lint * update logging * deprecate port flag * updating fetch ceil * adding concurrency during parse store * add comments * gen (stringer) * add build to .goreleaser.yml * build * Revert "build" [goreleaser] This reverts commit 8c61076. * fix goreleaser [goreleaser] * fix replacement issue * [sinner] add start readme (#1499) * add start readme * fix https://github.com/synapsecns/sanguine/pull/1380/files#r1371810612 --------- Co-authored-by: Trajan0x <[email protected]> * sinner strings for contract_type (#1498) Co-authored-by: Trajan0x <[email protected]> * trajan edits * nits * explorer update * Sinner: resolvers and updating db read functions (#1514) * init staging * add more db read functions * update model to where * update filters * hash * Revert "hash" This reverts commit 9b159df. * remove unused db mocks * handle invalid port --------- Co-authored-by: Trajan0x <[email protected]> * type fix * simplify w generics * add go error group to unified command + updated read.go * code rabbit nit * logger fix * Parser, API, and config updates * tests, sinner/indexer updates, db updates * lint + refactor graphql + db * Add log range asc to API * [goreleaser] * Update README.md * refactor indexer * exit 1 on fail * update scribe fetcher and pagination behavior * mysql context * mysql + refresh rate * update config and readme + [goreleaser] * update tests * typo + [goreleaser] * prom exporter gen * revert abi - [goreleaser] * [goreleaser] * specify varchar length for indexing [goreleaser] * update 64 to 66 to account for 0x [goreleaser] * update api * [goreleaser] * gen * update comment * [goreleaser] * add asc flag * [goroutine] * [goreleaser] --------- Co-authored-by: Trajan0x <[email protected]> Co-authored-by: trajan0x <[email protected]>
nautsimon
added a commit
that referenced
this pull request
Nov 4, 2023
* init * stashing at prev checkpoint to resolve build issues * updating graphql * live filling updates * stash prev changes before tests * update queries w/tests * update api and cli * stash before deploy * api tests * lint * lint * lint + gen * code cov * gen * adding code cov * lint + test + coderabbit suggestions * symlink * edits * hold * Update go.mod * sinner docker + main.go * sinner test flake, bytes -> hex string update, update assert use, lint * update logging * deprecate port flag * updating fetch ceil * adding concurrency during parse store * add comments * gen (stringer) * add build to .goreleaser.yml * build * Revert "build" [goreleaser] This reverts commit 8c61076. * fix goreleaser [goreleaser] * fix replacement issue * [sinner] add start readme (#1499) * add start readme * fix https://github.com/synapsecns/sanguine/pull/1380/files#r1371810612 --------- Co-authored-by: Trajan0x <[email protected]> * sinner strings for contract_type (#1498) Co-authored-by: Trajan0x <[email protected]> * trajan edits * nits * explorer update * Sinner: resolvers and updating db read functions (#1514) * init staging * add more db read functions * update model to where * update filters * hash * Revert "hash" This reverts commit 9b159df. * remove unused db mocks * handle invalid port --------- Co-authored-by: Trajan0x <[email protected]> * type fix * simplify w generics * add go error group to unified command + updated read.go * code rabbit nit * logger fix * Parser, API, and config updates * tests, sinner/indexer updates, db updates * lint + refactor graphql + db * Add log range asc to API * [goreleaser] * Update README.md * refactor indexer * exit 1 on fail * update scribe fetcher and pagination behavior * mysql context * mysql + refresh rate * update config and readme + [goreleaser] * init * mod lint * omnirpc version bump * chart bump * Update values.yaml * lint * rm omnirpc dependacy * update op rpc (ratelimited) * rev --------- Co-authored-by: Trajan0x <[email protected]> Co-authored-by: trajan0x <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title
Summary by CodeRabbit
ContractTypeenum in the Sinner service. The update introduces a more dynamic way of handlingContractTypevalues, reducing the risk of errors and making the code easier to update in the future. This change is internal and does not directly affect the user interface or functionality, but it contributes to the overall reliability of the system.