Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing chainId #1497

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Adds missing chainId #1497

merged 1 commit into from
Oct 24, 2023

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Oct 24, 2023

Summary by CodeRabbit

  • New Feature: Enhanced token information with the addition of 'chainId' for 'SYN_ETH_SUSHI_TOKEN' and 'ETH_USDC_SUSHI_TOKEN'. This update provides users with more detailed information about the blockchain network associated with these tokens, improving transparency and aiding in token management.

82489ce1216a0a78e736adadc622984459d8e24f: synapse-interface preview link

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2023

Walkthrough

The changes introduced in this diff primarily focus on adding a new property chainId to the SYN_ETH_SUSHI_TOKEN and ETH_USDC_SUSHI_TOKEN objects in the sushiMaster.ts file. This addition provides chain ID information for the tokens, enhancing the token's metadata.

Changes

File Summary
.../constants/tokens/sushiMaster.ts Introduced a new property chainId to SYN_ETH_SUSHI_TOKEN and ETH_USDC_SUSHI_TOKEN objects. The chainId is assigned the value of CHAINS.ETH.id, providing chain ID information for the tokens.

🐇

In the land of code, changes are afoot,

Tokens now have a chain, as they should.

With each pull request, we improve our loot,

Making our software as good as it could. 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6e09c74 and 4aa7762.
Files selected for processing (1)
  • packages/synapse-interface/constants/tokens/sushiMaster.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/constants/tokens/sushiMaster.ts

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1960f63) 51.28124% compared to head (4aa7762) 50.89018%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1497         +/-   ##
===================================================
- Coverage   51.28124%   50.89018%   -0.39106%     
===================================================
  Files            365         357          -8     
  Lines          25132       24321        -811     
  Branches         271         271                 
===================================================
- Hits           12888       12377        -511     
+ Misses         10978       10739        -239     
+ Partials        1266        1205         -61     
Flag Coverage Δ
cctp-relayer ?
packages 90.62003% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliusbtc aureliusbtc merged commit 93d5df2 into master Oct 24, 2023
42 checks passed
@aureliusbtc aureliusbtc deleted the fix/sushi-chainId branch October 24, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants