Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ToB-22 (using msg.value in a loop) #1453

Merged
merged 3 commits into from
Oct 23, 2023

Adjust BaseClient test

340f968
Select commit
Loading
Failed to load commit list.
Merged

Fix: ToB-22 (using msg.value in a loop) #1453

Adjust BaseClient test
340f968
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 12, 2023 in 1s

50.68798% (-0.00412%) compared to 2ee5234

View this Pull Request on Codecov

50.68798% (-0.00412%) compared to 2ee5234

Details

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2ee5234) 50.69210% compared to head (340f968) 50.68798%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1453         +/-   ##
===================================================
- Coverage   50.69210%   50.68798%   -0.00413%     
===================================================
  Files            356         356                 
  Lines          24274       24274                 
  Branches         267         267                 
===================================================
- Hits           12305       12304          -1     
  Misses         10775       10775                 
- Partials        1194        1195          +1     
Files Coverage Δ
...ges/contracts-core/contracts/client/BaseClient.sol 100.00000% <100.00000%> (ø)
...ntracts-core/contracts/client/MessageRecipient.sol 88.88889% <100.00000%> (-11.11111%) ⬇️
...contracts-core/contracts/client/PingPongClient.sol 100.00000% <100.00000%> (ø)
...ges/contracts-core/contracts/client/TestClient.sol 100.00000% <100.00000%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.