Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Devnet Scribe Config #1385

Closed
wants to merge 1 commit into from
Closed

Conversation

trajan0x
Copy link
Contributor

Description

This is not a prereq to #1381 but would be nice. Clears out a lot of deprecated config options from devnet config. Reason this is seperate is I can't quite test this locally rn

@trajan0x trajan0x requested a review from nautsimon September 15, 2023 17:46
@trajan0x trajan0x mentioned this pull request Sep 15, 2023
4 tasks
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.72064% ⚠️

Comparison is base (00cdb48) 50.89307% compared to head (5307a88) 48.17243%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/devnet-upper       #1385         +/-   ##
===========================================================
- Coverage           50.89307%   48.17243%   -2.72065%     
===========================================================
  Files                    354         351          -3     
  Lines                  24970       24103        -867     
  Branches                 277         277                 
===========================================================
- Hits                   12708       11611       -1097     
- Misses                 10984       11420        +436     
+ Partials                1278        1072        -206     
Flag Coverage Δ
agents 32.90070% <ø> (-14.24142%) ⬇️
cctp-relayer 63.33333% <ø> (ø)
explorer 25.43225% <ø> (ø)
promexporter 41.02564% <ø> (ø)
scribe 52.06408% <ø> (+0.18483%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trajan0x trajan0x marked this pull request as ready for review September 18, 2023 16:58
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 3, 2023
@github-actions github-actions bot closed this Oct 8, 2023
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2023

CodeRabbit review skipped

By default, CodeRabbit only reviews PRs on the default branch. If you wish to have PRs reviewed on additional branches, you can configure that under the repository settings in the UI.

@github-actions github-actions bot deleted the feat/fix-scribe-config branch December 19, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant