Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add messaging deploy block #1384

Closed
wants to merge 1 commit into from
Closed

Conversation

trajan0x
Copy link
Contributor

Description

Since the plan is to deploy #1381 before we resolve this:

In scribe configs, start_block should be the deploy block of the contract. This is especially important for executors since they need to rebuild the entire merkle tree from logs on each chain. In the past I've built a generate command that generates a scribe config based on a hardhat deploy folder using this parser. However this is not available for foundry. Do we know why this is/is there a way to fix this?

Wanted to create a new issue w/ a potential solution. This isn't my favorite approach, but I'd like to at least have a separate place to discuss this vs a deployer utils approach so this doesn't get lost pre-deploy. As such this'll be a draft

@github-actions github-actions bot added M-contracts Module: Contracts 2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. labels Sep 15, 2023
@trajan0x trajan0x mentioned this pull request Sep 15, 2023
4 tasks
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.40200% ⚠️

Comparison is base (b57714b) 50.88921% compared to head (676cb75) 50.48721%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1384         +/-   ##
===================================================
- Coverage   50.88921%   50.48721%   -0.40201%     
===================================================
  Files            353         343         -10     
  Lines          24966       24117        -849     
  Branches         277         277                 
===================================================
- Hits           12705       12176        -529     
+ Misses         10981       10722        -259     
+ Partials        1280        1219         -61     
Flag Coverage Δ
cctp-relayer ?
packages 83.42541% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 30, 2023
@github-actions github-actions bot closed this Oct 5, 2023
@github-actions github-actions bot deleted the feat/messaging-base-block branch December 19, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. M-contracts Module: Contracts size/xs Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant