Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused scribe config params #1383

Merged
merged 1 commit into from
Sep 15, 2023
Merged

remove unused scribe config params #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions services/scribe/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@ import (
type Config struct {
// Chains stores all chain information
Chains ChainConfigs `yaml:"chains"`
// RefreshRate is the rate at which the scribe will refresh the last block height in seconds.
RefreshRate uint `yaml:"refresh_rate"`
// RPCURL is the url of the omnirpc.
RPCURL string `yaml:"rpc_url"`
// ConfirmationRefreshRate is the rate at which the scribe will refresh the last confirmed block height in seconds.
ConfirmationRefreshRate int64 `yaml:"confirmation_refresh_rate"`
}

// IsValid makes sure the config is valid. This is done by calling IsValid() on each
Expand Down
3 changes: 1 addition & 2 deletions services/scribe/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ func (c ConfigSuite) TestConfigEncodeDecode() {
},
},
},
RefreshRate: uint(gofakeit.Uint8()),
RPCURL: gofakeit.URL(),
RPCURL: gofakeit.URL(),
}

encodedConfig, err := testConfig.Encode()
Expand Down
1 change: 0 additions & 1 deletion services/scribe/service/scribe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ func (s *ScribeSuite) TestLivefillParity() {
maticID: "https://api.polygonscan.com/api",
}
scribeConfig := config.Config{
RefreshRate: 1,
Chains: []config.ChainConfig{
{
ChainID: ethID,
Expand Down
Loading