Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused scribe config params #1383

Merged
merged 1 commit into from
Sep 15, 2023

remove unused params

9e01c3b
Select commit
Loading
Failed to load commit list.
Merged

remove unused scribe config params #1383

remove unused params
9e01c3b
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Sep 15, 2023 in 0s

50.94929% (+0.06008%) compared to b57714b

View this Pull Request on Codecov

50.94929% (+0.06008%) compared to b57714b

Details

Codecov Report

Patch coverage has no change and project coverage change: +0.06008% 🎉

Comparison is base (b57714b) 50.88921% compared to head (9e01c3b) 50.94929%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1383         +/-   ##
===================================================
+ Coverage   50.88921%   50.94929%   +0.06007%     
===================================================
  Files            353         353                 
  Lines          24966       24966                 
  Branches         277         277                 
===================================================
+ Hits           12705       12720         +15     
+ Misses         10981       10971         -10     
+ Partials        1280        1275          -5     
Files Changed Coverage Δ
services/scribe/config/config.go 37.50000% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.