Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sinner #1380
Sinner #1380
Changes from 72 commits
41d4839
7717370
fa87c69
b5b435a
67cf049
1e29933
e72e9cf
7e601d1
a4cffbc
d2881fc
d6c8ecf
da18611
d57d24e
6326b08
1be0a97
f635222
3b67b45
0da7982
a66dc9b
df0fdb9
1ab130e
a098dcf
45fd438
677f4b9
d568368
be9cd26
a5c2273
44c4b1e
b95faa6
8aa4cc6
69e3e9a
6aae818
514453d
61ca558
4f0ef6c
8c61076
a769d9b
431f63b
1df6180
60a9434
a5a0960
839902c
ae7426d
20e23da
2a59e49
3489db9
aa5d87d
3c85e93
c04199a
5e3e77f
cbcd01b
54561db
317df84
704bbfa
31dc07d
e69f6ce
4649eec
17f9fde
2f910b4
1a3f396
be702d1
889b9ef
bf594fa
5a2512d
90dcf30
bda1b9b
cd0a685
0625402
c535bdf
3f63283
141b7e1
a3972c8
88b4467
fc7f11c
ff8e7a3
f9c1142
d083937
8298d74
20e770f
c37b2d7
64c1cb0
526c562
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case for retrieving logs in ascending order is not correct. The
GetLogsRange
function is called with the start block number greater than the end block number. This might not return the expected results. The start block number should be less than or equal to the end block number. If you want to retrieve logs in ascending order, you should modify theGetLogsRange
function to sort the results based on the block number.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case for checking the last and first stored block numbers is not correct. The test case assumes that the last and first stored block numbers are the same, which might not be the case in a real-world scenario. You should store multiple block times with different block numbers and then check the last and first stored block numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case for checking the last indexed block number is not correct. The test case assumes that the last indexed block number is the same as the block number used to store the last indexed block. However, the last indexed block number should be retrieved from the database and not assumed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case for checking the last confirmed block number is not correct. The test case assumes that the last confirmed block number is the same as the block number used to store the last confirmed block. However, the last confirmed block number should be retrieved from the database and not assumed.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.