Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes legacy dispatched type from OriginHub #1370

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Sep 13, 2023

Description

Removes now unused Dispatch type from OriginHub

@github-actions github-actions bot added M-contracts Module: Contracts go Pull requests that update Go code 2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. size/m labels Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@1d50890). Click here to learn what that means.
Patch coverage: 52.65911% of modified lines in pull request are covered.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master       #1370   +/-   ##
============================================
  Coverage          ?   56.69889%           
============================================
  Files             ?         472           
  Lines             ?       32789           
  Branches          ?         277           
============================================
  Hits              ?       18591           
  Misses            ?       12493           
  Partials          ?        1705           
Flag Coverage Δ
agents 47.08967% <52.65911%> (?)
packages 83.42541% <ø> (?)
solidity 93.00244% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
agents/config/agent_config.go 0.00000% <ø> (ø)
agents/config/executor/config.go 44.44444% <ø> (ø)
agents/config/scribe.go 0.00000% <ø> (ø)
agents/testutil/simulated_backends_suite.go 0.00000% <0.00000%> (ø)
agents/testutil/typecast.go 6.25000% <0.00000%> (ø)
agents/types/agent_status.go 0.00000% <0.00000%> (ø)
agents/types/chain_gas.go 50.00000% <0.00000%> (ø)
agents/types/dispute_status.go 0.00000% <0.00000%> (ø)
agents/types/fraud_attestation.go 0.00000% <0.00000%> (ø)
agents/types/fraud_snapshot.go 0.00000% <0.00000%> (ø)
... and 26 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trajan0x trajan0x marked this pull request as ready for review September 13, 2023 23:10
@trajan0x
Copy link
Contributor Author

ignore codecov for this, this was caused by [ci skip] being in the commit body when #1280 was merged

@trajan0x trajan0x merged commit 0f1e7e2 into master Sep 14, 2023
@trajan0x trajan0x deleted the feat/remove-dispatched branch September 14, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. go Pull requests that update Go code M-contracts Module: Contracts size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant