add test contract and contract backfill to get logs #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
===================================================
+ Coverage 51.45197% 52.81948% +1.36750%
===================================================
Files 132 134 +2
Lines 5372 5462 +90
Branches 73 73
===================================================
+ Hits 2764 2885 +121
+ Misses 2337 2298 -39
- Partials 271 279 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
trajan0x
approved these changes
Aug 25, 2022
|
|
||
| // TestGetLogsMock tests the GetLogs function using a mocked blockchain for errors. | ||
| func (b BackfillSuite) TestGetLogsMock() { | ||
| // TODO: do this with mocks |
There was a problem hiding this comment.
let's make this comment a little clearer - "for error handling in GetLogs methods"
scribe/backfill/suite_test.go
Outdated
| return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?parseTime=true", common.GetEnv("MYSQL_USER", "root"), os.Getenv("MYSQL_PASSWORD"), common.GetEnv("MYSQL_HOST", "127.0.0.1"), common.GetEnvInt("MYSQL_PORT", 3306), dbname) | ||
| } | ||
|
|
||
| func (b *BackfillSuite) setupMysqlDB() { |
There was a problem hiding this comment.
no need to test against multiple dbs here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the scribe (#114), there is a need for backlogging logs from transactions that occurred. This is going to eventually pair with a live watcher that will add logs and receipts to the database in real time. Right now, this PR merely gets logs from a certain blockheight to another blockheight.