Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Sdk/cleanup fe #1356

Closed
wants to merge 53 commits into from
Closed

[DO NOT MERGE] Sdk/cleanup fe #1356

wants to merge 53 commits into from

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Sep 12, 2023

Preview for #1355, can be closed after that pr is merged

addd1a5f5169c954003b6f773b478438df275a69: synapse-interface preview link
851cd843fdb78b2f826614439eae4fec48f7bb9e: synapse-interface preview link
5a827d15973c49b5d33fc2b364bfd0e7320c1584: synapse-interface preview link

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@918ff67). Click here to learn what that means.
Patch coverage: 96.74556% of modified lines in pull request are covered.
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master       #1356   +/-   ##
============================================
  Coverage          ?   60.37621%           
============================================
  Files             ?         545           
  Lines             ?       32960           
  Branches          ?         268           
============================================
  Hits              ?       19900           
  Misses            ?       11272           
  Partials          ?        1788           
Flag Coverage Δ
packages 90.41534% <96.74556%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/sdk-router/src/router/router.ts 80.95238% <80.95238%> (ø)
...ages/sdk-router/src/router/synapseCCTPRouterSet.ts 85.71429% <85.71429%> (ø)
packages/sdk-router/src/operations/swap.ts 87.50000% <87.50000%> (ø)
packages/sdk-router/src/router/types.ts 88.88889% <88.88889%> (ø)
packages/sdk-router/src/router/routerSet.ts 95.45455% <95.45455%> (ø)
packages/sdk-router/src/operations/pools.ts 96.66667% <96.66667%> (ø)
packages/sdk-router/src/constants/addresses.ts 100.00000% <100.00000%> (ø)
packages/sdk-router/src/constants/chainIds.ts 100.00000% <100.00000%> (ø)
packages/sdk-router/src/constants/index.ts 100.00000% <100.00000%> (ø)
packages/sdk-router/src/constants/testValues.ts 100.00000% <100.00000%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChiTimesChi ChiTimesChi changed the title Sdk/cleanup fe [DO NOT MERGE] Sdk/cleanup fe Sep 13, 2023
@ChiTimesChi ChiTimesChi mentioned this pull request Sep 15, 2023
@ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi deleted the sdk/cleanup-fe branch September 15, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants