-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fraud Report Final Touches 🎉 #1339
Conversation
a26b07d
to
503ea1c
Compare
515b990
to
01afb2e
Compare
Co-authored-by: Trajan0x <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/fraud-reports #1339 +/- ##
========================================================
Coverage ? 48.24479%
========================================================
Files ? 278
Lines ? 22305
Branches ? 0
========================================================
Hits ? 10761
Misses ? 10366
Partials ? 1178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- name: Test | ||
uses: nick-fields/retry@v2 | ||
with: | ||
command: | | ||
set -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation: Why the Script Didn't Stop on Errors
The provided script looped through each package and ran a series of commands on each package. If any command failed during this process, the script would simply continue to the next package in the list without stopping.
This behavior is due to the default nature of bash scripting. By default, a bash script won't terminate or exit just because a command inside it fails. Instead, it will continue executing subsequent commands.
If you want a bash script to exit immediately when a command fails, you need to add the set -e
directive at the beginning of the script. The set -e
directive instructs the shell to exit immediately if any command in the script returns a non-zero exit status (indicating failure).
Without the set -e
directive, your script will continue running subsequent commands even if one of them fails, which is the behavior you observed.
7424c17
to
1cb0814
Compare
Description
Tracking in: #1280 (comment)