needs-go-generate labels are not removed
#1397
Comments
trajan0x
added a commit
that referenced
this issue
Sep 25, 2023
4 tasks
trajan0x
added a commit
that referenced
this issue
Sep 25, 2023
As #1397 & #579 pointed out if a module is changed and then unchanged, the needs-go-generate action is not removed (this is blocking #1382 rn). For this reason, this pr: - consolidates actions for `include_deps`=true and `include_deps`=false. This will also help with #1390 by halving api requests by git-changes-action. Further work could be done here by consolidating goreleaser into `go.yml` the future - Remove unchanged module labels. This is honestly kind of a pain and could lead to api rate limiting issues. The way we're going to deal with this is by starting an action for each label, but only running it if the event is a pull request and [this condition](https://stackoverflow.com/a/59588725) is met. Once this is done we can also add this to the needs-go-generate check to reduce the number of api calls to remove a lebl further helping w/ #1390 --------- Co-authored-by: Trajan0x <[email protected]>
|
Fixed in #1399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An old PR could get a bunch of
needs-go-generatelabels if it is behind master, see for example:https://github.com/synapsecns/sanguine/actions/runs/6265362203/job/17047824402
However, once the
masterbranch is merged into the branch in question, the labels persist. This is due to the wholeGo Generate (Module Changes)workflow being skipped on no changes:https://github.com/synapsecns/sanguine/actions/runs/6265608504/job/17048082573
The desired behavior would be: when no changes are detected for a module, the
needs-go-generatelabel for the module should be removed (if there is one).The text was updated successfully, but these errors were encountered: