Add tests for "apply slippage" not modifying the passed object

synapsecns · Dec 27, 2023 · dbff955 · dbff955
1 parent 43ed59f
commit dbff955
Showing 1 changed file with 33 additions and 0 deletions.
diff --git a/packages/sdk-router/src/module/query.test.ts b/packages/sdk-router/src/module/query.test.ts
@@ -193,6 +193,17 @@ describe('#query', () => {
           rawParams: '5',
         })
       })
+
+      it('does not modify the original query', () => {
+        applySlippage(query, 50, 10000)
+        expect(query).toEqual({
+          swapAdapter: '1',
+          tokenOut: '2',
+          minAmountOut: BigNumber.from(10).pow(18).mul(1_000_000),
+          deadline: BigNumber.from(4),
+          rawParams: '5',
+        })
+      })
     })
 
     describe('CCTPRouterQuery', () => {
@@ -261,6 +272,17 @@ describe('#query', () => {
           rawParams: '5',
         })
       })
+
+      it('does not modify the original query', () => {
+        applySlippage(query, 50, 10000)
+        expect(query).toEqual({
+          routerAdapter: '1',
+          tokenOut: '2',
+          minAmountOut: BigNumber.from(10).pow(6).mul(1_000_000),
+          deadline: BigNumber.from(4),
+          rawParams: '5',
+        })
+      })
     })
 
     describe('errors', () => {
@@ -326,6 +348,17 @@ describe('#query', () => {
       expect(newQuery).toEqual(newQueryInBips)
     })
 
+    it('does not modify the original query', () => {
+      applySlippageInBips(query, 50)
+      expect(query).toEqual({
+        swapAdapter: '1',
+        tokenOut: '2',
+        minAmountOut: BigNumber.from(10).pow(18).mul(1_000_000),
+        deadline: BigNumber.from(4),
+        rawParams: '5',
+      })
+    })
+
     it('throws if basis points are negative', () => {
       expect(() => applySlippageInBips(routerQuery, -1)).toThrow(
         'Slippage numerator cannot be negative'