fix compare logic

synapsecns · Sep 23, 2024 · c63eb5d · c63eb5d
1 parent f74ca92
commit c63eb5d
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/packages/synapse-interface/components/StateManagedBridge/hooks/useConfirmNewBridgePrice.ts b/packages/synapse-interface/components/StateManagedBridge/hooks/useConfirmNewBridgePrice.ts
@@ -71,19 +71,18 @@ export const useConfirmNewBridgePrice = () => {
     if (
       validQuotes &&
       hasSameSelectionsAsPreviousQuote &&
-      hasBridgeModuleChanged
-    ) {
-      requestUserConfirmChange(previousBridgeQuote)
-    } else if (
-      validQuotes &&
-      hasSameSelectionsAsPreviousQuote &&
-      outputAmountDiffMoreThanThreshold
+      (outputAmountDiffMoreThanThreshold || hasBridgeModuleChanged)
     ) {
       requestUserConfirmChange(previousBridgeQuote)
     } else {
       resetConfirm()
     }
-  }, [bridgeQuote, previousBridgeQuote, hasSameSelectionsAsPreviousQuote])
+  }, [
+    bridgeQuote,
+    previousBridgeQuote,
+    hasSameSelectionsAsPreviousQuote,
+    isPendingConfirmChange,
+  ])
 
   const requestUserConfirmChange = (previousQuote: BridgeQuote) => {
     if (!hasQuoteOutputChanged && !hasUserConfirmedChange) {
@@ -123,5 +122,5 @@ const calculateOutputRelativeDifference = (
   const currentOutput = parseFloat(currentQuote.outputAmountString)
   const previousOutput = parseFloat(currentQuote.outputAmountString)
 
-  return previousOutput - currentOutput / previousOutput
+  return (previousOutput - currentOutput) / previousOutput
 }