Skip to content

Commit

Permalink
[Scribe] remove unused config params (#1383)
Browse files Browse the repository at this point in the history
Co-authored-by: Trajan0x <[email protected]>
  • Loading branch information
trajan0x and trajan0x authored Sep 15, 2023
1 parent e480b2b commit 98c4d3b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
4 changes: 0 additions & 4 deletions services/scribe/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@ import (
type Config struct {
// Chains stores all chain information
Chains ChainConfigs `yaml:"chains"`
// RefreshRate is the rate at which the scribe will refresh the last block height in seconds.
RefreshRate uint `yaml:"refresh_rate"`
// RPCURL is the url of the omnirpc.
RPCURL string `yaml:"rpc_url"`
// ConfirmationRefreshRate is the rate at which the scribe will refresh the last confirmed block height in seconds.
ConfirmationRefreshRate int64 `yaml:"confirmation_refresh_rate"`
}

// IsValid makes sure the config is valid. This is done by calling IsValid() on each
Expand Down
3 changes: 1 addition & 2 deletions services/scribe/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ func (c ConfigSuite) TestConfigEncodeDecode() {
},
},
},
RefreshRate: uint(gofakeit.Uint8()),
RPCURL: gofakeit.URL(),
RPCURL: gofakeit.URL(),
}

encodedConfig, err := testConfig.Encode()
Expand Down
1 change: 0 additions & 1 deletion services/scribe/service/scribe_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ func (s *ScribeSuite) TestLivefillParity() {
maticID: "https://api.polygonscan.com/api",
}
scribeConfig := config.Config{
RefreshRate: 1,
Chains: []config.ChainConfig{
{
ChainID: ethID,
Expand Down

0 comments on commit 98c4d3b

Please sign in to comment.