Feat: add TestShouldProcess

synapsecns · Dec 20, 2023 · 23d2838 · 23d2838
1 parent 583da87
commit 23d2838
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 2 deletions.
diff --git a/services/rfq/relayer/quoter/quoter.go b/services/rfq/relayer/quoter/quoter.go
@@ -108,8 +108,8 @@ func (m *Manager) isProfitableQuote(ctx context.Context, quote reldb.QuoteReques
 		return false, fmt.Errorf("error getting total fee: %w", err)
 	}
 	// NOTE: this logic assumes that the origin and destination tokens have the same price.
-	cost := new(big.Int).Sub(quote.Transaction.DestAmount, fee)
-	return quote.Transaction.OriginAmount.Cmp(cost) > 0, nil
+	cost := new(big.Int).Add(quote.Transaction.DestAmount, fee)
+	return quote.Transaction.OriginAmount.Cmp(cost) >= 0, nil
 }
 
 // SubmitAllQuotes submits all quotes to the RFQ API.

diff --git a/services/rfq/relayer/quoter/quoter_test.go b/services/rfq/relayer/quoter/quoter_test.go
@@ -6,6 +6,8 @@ import (
 
 	"github.com/ethereum/go-ethereum/common"
 	rfqAPIClient "github.com/synapsecns/sanguine/services/rfq/api/client"
+	"github.com/synapsecns/sanguine/services/rfq/contracts/fastbridge"
+	"github.com/synapsecns/sanguine/services/rfq/relayer/reldb"
 )
 
 func (s *QuoterSuite) TestGenerateQuotes() {
@@ -28,3 +30,47 @@ func (s *QuoterSuite) TestGenerateQuotes() {
 	}
 	s.Equal(quotes, expectedQuotes)
 }
+
+func (s *QuoterSuite) TestShouldProcess() {
+	// Set fee to breakeven; i.e. destAmount = originAmount - fee.
+	balance := big.NewInt(1000_000_000) // 1000 USDC
+	fee := big.NewInt(100_050_000)      // 100.05 USDC
+	quote := reldb.QuoteRequest{
+		BlockNumber:         1,
+		OriginTokenDecimals: 6,
+		DestTokenDecimals:   6,
+		Transaction: fastbridge.IFastBridgeBridgeTransaction{
+			OriginChainId: s.origin,
+			DestChainId:   s.destination,
+			OriginToken:   common.HexToAddress("0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48"),
+			DestToken:     common.HexToAddress("0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85"),
+			OriginAmount:  balance,
+			DestAmount:    new(big.Int).Sub(balance, fee),
+		},
+	}
+	s.True(s.manager.ShouldProcess(s.GetTestContext(), quote))
+
+	// Set fee to greater than breakeven; i.e. destAmount > originAmount - fee.
+	quote.Transaction.DestAmount = new(big.Int).Sub(balance, new(big.Int).Mul(fee, big.NewInt(2)))
+	s.True(s.manager.ShouldProcess(s.GetTestContext(), quote))
+
+	// Set fee to less than breakeven; i.e. destAmount < originAmount - fee.
+	quote.Transaction.DestAmount = balance
+	s.False(s.manager.ShouldProcess(s.GetTestContext(), quote))
+
+	// Set different numbers of decimals for origin / dest tokens; should never process this.
+	quote = reldb.QuoteRequest{
+		BlockNumber:         1,
+		OriginTokenDecimals: 6,
+		DestTokenDecimals:   18,
+		Transaction: fastbridge.IFastBridgeBridgeTransaction{
+			OriginChainId: s.origin,
+			DestChainId:   s.destination,
+			OriginToken:   common.HexToAddress("0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48"),
+			DestToken:     common.HexToAddress("0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85"),
+			OriginAmount:  balance,
+			DestAmount:    new(big.Int).Sub(balance, fee),
+		},
+	}
+	s.False(s.manager.ShouldProcess(s.GetTestContext(), quote))
+}