Skip to content

Commit

Permalink
url
Browse files Browse the repository at this point in the history
  • Loading branch information
trajan0x committed Sep 11, 2024
1 parent 8a04f9e commit 0e3a5ae
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions core/metrics/otlp.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ func makeOTLPExporter(ctx context.Context, envSuffix string) (*otlptrace.Exporte
return nil, fmt.Errorf("could not create exporter: secure mode is not set correctly")
}

Check warning on line 151 in core/metrics/otlp.go

View check run for this annotation

Codecov / codecov/patch

core/metrics/otlp.go#L150-L151

Added lines #L150 - L151 were not covered by tests

if url == "" {
return nil, fmt.Errorf("could not create exporter: url is empty")
}

// I spent about 2 hours trying to figure out why this was failing to no avail. I'm going to leave it as is for now.
// My best guess is the issue is around the tsl config.
// Should you attempt to fix this and fail, please increment the counter above, although I send my umost encouragement.
Expand Down

0 comments on commit 0e3a5ae

Please sign in to comment.