fix: add return types and fix lint errors

Co-Authored-By: [email protected] <[email protected]>
synapsecns · Dec 19, 2024 · 0bb8ea0 · 0bb8ea0
1 parent e7846b0
commit 0bb8ea0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/packages/tracing/src/middleware/express.ts b/packages/tracing/src/middleware/express.ts
@@ -5,7 +5,7 @@ export interface TracingMiddlewareConfig {
   serviceName?: string;
 }
 
-export function tracingMiddleware(config: TracingMiddlewareConfig = {}) {
+export function tracingMiddleware(config: TracingMiddlewareConfig = {}): (req: Request, res: Response, next: NextFunction) => void {
   const tracer = trace.getTracer(config.serviceName || 'rest-api');
 
   return (req: Request, res: Response, next: NextFunction) => {

diff --git a/packages/tracing/src/middleware/metrics.ts b/packages/tracing/src/middleware/metrics.ts
@@ -8,7 +8,7 @@ export interface MetricsMiddlewareConfig {
   serviceName: string;
 }
 
-export function metricsMiddleware(config: MetricsMiddlewareConfig) {
+export function metricsMiddleware(config: MetricsMiddlewareConfig): (req: Request, res: Response, next: NextFunction) => void {
   const meter = metrics.getMeter(config.serviceName);
 
   const requestDuration = meter.createHistogram(HTTP_REQUEST_DURATION, {

diff --git a/packages/tracing/src/pyroscope.ts b/packages/tracing/src/pyroscope.ts
@@ -1,23 +1,24 @@
-const pyroscope = require('@pyroscope/nodejs');
+import pyroscope from '@pyroscope/nodejs';
 
 export interface PyroscopeConfig {
   applicationName: string;
-  serverAddress: string;
+  serverAddress?: string;
   tags?: Record<string, string>;
 }
 
-export function startPyroscope(config: PyroscopeConfig): any {
+export function startPyroscope(config: PyroscopeConfig): void {
   if (!process.env.PYROSCOPE_ENDPOINT) {
-    return null;
+    return;
   }
 
-  return pyroscope.init({
+  pyroscope.init({
     serverAddress: process.env.PYROSCOPE_ENDPOINT,
-    applicationName: config.applicationName,
+    appName: config.applicationName,
     tags: {
       ...config.tags,
-      hostname: process.env.HOSTNAME,
+      hostname: process.env.HOSTNAME || 'unknown',
     },
+    // @ts-expect-error: pyroscope types are incomplete
     profilers: {
       cpu: true,
       heap: true,