Support PHPStan 2.0 #144

zonuexe · 2024-11-13T07:42:23Z

All packages that are not compatible with PHPStan 2.0 have been temporarily removed.

refs rectorphp/rector#8815

zonuexe · 2024-11-13T07:44:52Z

I thought I needed a RuleErrorBuilderRector that works with PHPStan 1.x 😜

zonuexe · 2024-11-13T10:54:28Z

All tests pass in my environment.

TomasVotruba · 2024-11-13T10:55:34Z

src/Rules/ForbiddenMultipleClassLikeInOneFileRule.php

-    /**
-     * @param FileNode $node
-     * @return string[]
-     */
    public function processNode(Node $node, Scope $scope): array


The @param should remain, so IDE can fill the methods on $node

Ok, that doesn't make sense for an IDE that supports generics, but let's restore it.

My lattest PHPStorm still doesn't. What IDE do you use?

Without param type:

With param type:

This is why: #144 (review)

zonuexe · 2024-11-13T11:29:21Z

I have to hurry up and catch a long-distance bus now, but I've finished what I can do.

ondrejmirtes · 2024-11-14T09:35:46Z

src/Rules/ForbiddenMultipleClassLikeInOneFileRule.php

 use Symplify\RuleDocGenerator\Contract\DocumentedRuleInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

 /**
+ * @implements <FileNode>


The autocompletion does not work because this should say @implements Rule<FileNode>.

JoyceBabu · 2024-11-23T12:05:28Z

src/Rules/ForbiddenMultipleClassLikeInOneFileRule.php

@@ -17,7 +17,7 @@
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

 /**
- * @implements <FileNode>
+ * @implements Node<FileNode>


Shouldn't this be Rule<FileNode>

Yes. Running PHPStan on the code will report that.

samsonasik · 2024-11-26T06:13:37Z

composer.json

        "symplify/rule-doc-generator": "^12.2",
        "phpunit/phpunit": "^10.5",
        "symfony/framework-bundle": "6.1.*",
-        "rector/rector": "^1.2.3",


could you use

"rector/rector": "dev-main as 1.2.10",

to test rector for CI?

I applied it to f83aafa

samsonasik · 2024-11-27T05:37:26Z

.github/workflows/code_analysis.yaml

@@ -22,6 +22,7 @@ jobs:

                    -
                        name: 'Rector'
+                        if: ${{ false }} # Temporarily disabled as it is not compatible with PHPStan 2.0


Could you revert this, rector should run now

reverted a6be6a1 d8fb908

src/Rules/CheckClassNamespaceFollowPsr4Rule.php

…an 2.0

…n 2.0" This reverts commit 18efdf5.

samsonasik · 2024-11-27T07:25:58Z

src/Rules/AnnotateRegexClassConstWithRegexLinkRule.php

@@ -69,7 +67,7 @@ public function processNode(Node $node, Scope $scope): array
            return [];
        }

-        return [self::ERROR_MESSAGE];
+        return [RuleErrorBuilder::message(self::ERROR_MESSAGE)->build()];


add identifier here as well

samsonasik · 2024-11-27T07:26:15Z

src/Rules/CheckRequiredInterfaceInContractNamespaceRule.php

@@ -53,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array
            return [];
        }

-        return [self::ERROR_MESSAGE];
+        return [RuleErrorBuilder::message(self::ERROR_MESSAGE)->build()];


add identifier here as well

samsonasik · 2024-11-27T07:26:20Z

src/Rules/ClassNameRespectsParentSuffixRule.php

@@ -132,7 +131,7 @@ private function processClassNameAndShort(ClassReflection $classReflection): arr
            }

            $errorMessage = sprintf(self::ERROR_MESSAGE, $expectedSuffix);
-            return [$errorMessage];
+            return [RuleErrorBuilder::message($errorMessage)->build()];


add identifier here as well

samsonasik · 2024-11-27T07:26:23Z

src/Rules/Complexity/ForbiddenArrayMethodCallRule.php

@@ -58,7 +56,7 @@ public function processNode(Node $node, Scope $scope): array
            return [];
        }

-        return [self::ERROR_MESSAGE];
+        return [RuleErrorBuilder::message(self::ERROR_MESSAGE)->build()];


add identifier here as well

samsonasik · 2024-11-27T07:26:27Z

src/Rules/Domain/RequireAttributeNamespaceRule.php

@@ -74,6 +75,6 @@ public function processNode(Node $node, Scope $scope): array
            return [];
        }

-        return [self::ERROR_MESSAGE];
+        return [RuleErrorBuilder::message(self::ERROR_MESSAGE)->build()];


add identifier here as well

samsonasik · 2024-11-27T07:26:53Z

src/Rules/Domain/RequireExceptionNamespaceRule.php

@@ -77,6 +75,6 @@ public function processNode(Node $node, Scope $scope): array
            return [];
        }

-        return [self::ERROR_MESSAGE];
+        return [RuleErrorBuilder::message(self::ERROR_MESSAGE)->build()];


add identifier here as well, basically, add unique identifier on message error

mitelg · 2024-11-29T12:19:26Z

hey @zonuexe

thanks for your current work! 💪 we are currently waiting for this extension to be compatible with PHPStan 2, so I want to offer my help 🙂 let me know, if I can somehow support here

zonuexe marked this pull request as draft November 13, 2024 07:42

zonuexe force-pushed the migrate/phpstan-2.0 branch from 9dce5c1 to c823f54 Compare November 13, 2024 10:52

zonuexe marked this pull request as ready for review November 13, 2024 10:54

TomasVotruba reviewed Nov 13, 2024

View reviewed changes

zonuexe force-pushed the migrate/phpstan-2.0 branch 2 times, most recently from e66aa45 to 7986458 Compare November 13, 2024 11:13

ondrejmirtes suggested changes Nov 14, 2024

View reviewed changes

JoyceBabu reviewed Nov 23, 2024

View reviewed changes

samsonasik reviewed Nov 26, 2024

View reviewed changes

zonuexe added 8 commits November 27, 2024 04:38

Temporarily remove packages that are not compatible with PHPStan 2.0

f83aafa

Make rules use RuleErrorBuilder

2d8e399

Skip tests that depend on Rector as incomplete

9e92a5c

Add PhpParser\PrettyPrinter\Standard to DI config file

921cf28

Comment out rules that are not PHPStan 2.0 compatible

5f72717

Temporarily disable steps that are not compatible with PHPStan 2.0

18efdf5

Disable symplify's own error-format

afebf42

fixup! Make rules use RuleErrorBuilder

e9c6e15

zonuexe force-pushed the migrate/phpstan-2.0 branch from 4678d29 to e9c6e15 Compare November 26, 2024 19:38

zonuexe requested review from TomasVotruba and samsonasik November 26, 2024 19:43

samsonasik reviewed Nov 27, 2024

View reviewed changes

src/Rules/CheckClassNamespaceFollowPsr4Rule.php Outdated Show resolved Hide resolved

zonuexe added 3 commits November 27, 2024 14:54

fixup! Temporarily remove packages that are not compatible with PHPSt…

a6be6a1

…an 2.0

Revert "Temporarily disable steps that are not compatible with PHPSta…

d8fb908

…n 2.0" This reverts commit 18efdf5.

Add Rule identifier

c8b2513

zonuexe requested a review from samsonasik November 27, 2024 05:57

fixup! Skip tests that depend on Rector as incomplete

78679b7

fixup! Make rules use RuleErrorBuilder

66b658e

samsonasik reviewed Nov 27, 2024

View reviewed changes

zonuexe marked this pull request as draft November 27, 2024 07:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support PHPStan 2.0 #144

Support PHPStan 2.0 #144

zonuexe commented Nov 13, 2024 •

edited

Loading

zonuexe commented Nov 13, 2024

zonuexe commented Nov 13, 2024

TomasVotruba Nov 13, 2024 •

edited

Loading

zonuexe Nov 13, 2024

TomasVotruba Nov 13, 2024 •

edited

Loading

ondrejmirtes Nov 14, 2024

zonuexe commented Nov 13, 2024

ondrejmirtes Nov 14, 2024

zonuexe Nov 14, 2024

JoyceBabu Nov 23, 2024

ondrejmirtes Nov 23, 2024

zonuexe Nov 26, 2024

samsonasik Nov 26, 2024

zonuexe Nov 26, 2024

samsonasik Nov 27, 2024

zonuexe Nov 27, 2024

samsonasik Nov 27, 2024

samsonasik Nov 27, 2024

samsonasik Nov 27, 2024

samsonasik Nov 27, 2024

samsonasik Nov 27, 2024

samsonasik Nov 27, 2024

mitelg commented Nov 29, 2024

Support PHPStan 2.0 #144

Are you sure you want to change the base?

Support PHPStan 2.0 #144

Conversation

zonuexe commented Nov 13, 2024 • edited Loading

zonuexe commented Nov 13, 2024

zonuexe commented Nov 13, 2024

TomasVotruba Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomasVotruba Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zonuexe commented Nov 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitelg commented Nov 29, 2024

zonuexe commented Nov 13, 2024 •

edited

Loading

TomasVotruba Nov 13, 2024 •

edited

Loading

TomasVotruba Nov 13, 2024 •

edited

Loading