misc

symplify · May 18, 2024 · 57729c4 · 57729c4
1 parent 1cab76b
commit 57729c4
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 123 deletions.
diff --git a/config/services/services.neon b/config/services/services.neon
@@ -12,7 +12,6 @@ services:
     - Symplify\PHPStanRules\Composer\Psr4PathValidator
     - Symplify\PHPStanRules\Formatter\RequiredWithMessageFormatter
     - Symplify\PHPStanRules\Location\DirectoryChecker
-    - Symplify\PHPStanRules\Naming\BoolishNameAnalyser
     - Symplify\PHPStanRules\Naming\ClassToSuffixResolver
     - Symplify\PHPStanRules\NodeAnalyzer\AttributeFinder
     - Symplify\PHPStanRules\NodeAnalyzer\EnumAnalyzer

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 48 Rules Overview
+# 46 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -31,40 +31,6 @@ class SomeClass
 
 <br>
 
-## BoolishClassMethodPrefixRule
-
-Method `"%s()"` returns bool type, so the name should start with is/has/was...
-
-- class: [`Symplify\PHPStanRules\Rules\BoolishClassMethodPrefixRule`](../src/Rules/BoolishClassMethodPrefixRule.php)
-
-```php
-class SomeClass
-{
-    public function old(): bool
-    {
-        return $this->age > 100;
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeClass
-{
-    public function isOld(): bool
-    {
-        return $this->age > 100;
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## CheckClassNamespaceFollowPsr4Rule
 
 Class like namespace "%s" does not follow PSR-4 configuration in `composer.json`
@@ -616,44 +582,6 @@ interface RunnableInterface
 
 <br>
 
-## NoAbstractRule
-
-Instead of abstract class, use specific service with composition
-
-- class: [`Symplify\PHPStanRules\Rules\Complexity\NoAbstractRule`](../src/Rules/Complexity/NoAbstractRule.php)
-
-```php
-final class NormalHelper extends AbstractHelper
-{
-}
-
-abstract class AbstractHelper
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-final class NormalHelper
-{
-    public function __construct(
-        private SpecificHelper $specificHelper
-    ) {
-    }
-}
-
-final class SpecificHelper
-{
-}
-```
-
-:+1:
-
-<br>
-
 ## NoArrayAccessOnObjectRule
 
 Use explicit methods over array access on object

diff --git a/src/Naming/BoolishNameAnalyser.php b/src/Naming/BoolishNameAnalyser.php
diff --git a/src/ReturnTypeExtension/NodeGetAttributeTypeExtension.php b/src/ReturnTypeExtension/NodeGetAttributeTypeExtension.php
@@ -22,6 +22,7 @@
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
 /**
+ * @api used in rector rules
  * @see \Symplify\PHPStanRules\Tests\ReturnTypeExtension\NodeGetAttributeTypeExtension\NodeGetAttributeTypeExtensionTest
  */
 final class NodeGetAttributeTypeExtension implements DynamicMethodReturnTypeExtension

diff --git a/stubs/Symfony/Component/Console/Command.php b/stubs/Symfony/Component/Console/Command.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\Console\Command;
+
+if (class_exists('Symfony\Component\Console\Command\Command')) {
+    return;
+}
+
+class Command
+{
+}