Split request URI into SCRIPT_NAME and PATH_INFO by Sympa itself #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra-path of script-URI inproperly, we'd be better to reconstruct them: SCRIPT_NAME and PATH_INFO. Note that we shouldn't use non-standard CGI environment varialbes such as REQUEST_URI. - Additional environment variable SYMPA_DOMAIN stands for available mail domain (a.k.a. "robot"). - If no robot providing web service was found according to client's request, error response will be returned.
ikedas
added a commit
that referenced
this pull request
Mar 18, 2020
Replace `http_host` parameter with `wwsympa_url_local` parameter (addition to #910)
mmilata
added a commit
to mmilata/nixpkgs
that referenced
this pull request
Jun 10, 2020
Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was incorrect when webLocation was set to "/". Since Sympa 6.2.56 this has caused the web interface to return "421 Misdirected Request". Since 6.2.56 Sympa can do the splitting on its own so we can simply remove it from nginx configuration. See also: - sympa-community/sympa#879 - sympa-community/sympa#910 - sympa-community/sympa-community.github.io#53
10 tasks
mmilata
added a commit
to mmilata/nixpkgs
that referenced
this pull request
Jun 10, 2020
Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was incorrect when webLocation was set to "/". Since Sympa 6.2.56 this has caused the web interface to return "421 Misdirected Request". Since 6.2.56 Sympa can do the splitting on its own so we can simply remove it from nginx configuration. See also: - sympa-community/sympa#879 - sympa-community/sympa#910 - sympa-community/sympa-community.github.io#53 (cherry picked from commit bd4e4dd)
sorki
pushed a commit
to otevrenamesta/nixpkgs
that referenced
this pull request
Mar 10, 2021
Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was incorrect when webLocation was set to "/". Since Sympa 6.2.56 this has caused the web interface to return "421 Misdirected Request". Since 6.2.56 Sympa can do the splitting on its own so we can simply remove it from nginx configuration. See also: - sympa-community/sympa#879 - sympa-community/sympa#910 - sympa-community/sympa-community.github.io#53 (cherry picked from commit bd4e4dd)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we shouldn't use non-standard CGI environment varialbes such as REQUEST_URI.
This may fix #879 .