Remove 'confirm_action' from list of actions requiring the CSRF token #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikedas
added a commit
that referenced
this pull request
Jan 16, 2019
Remove 'confirm_action' from list of actions requiring the CSRF token
|
@mpkut, thanks for follow up. Merged to a tentative branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CSRF code is configured to require the token for the
confirm_actionaction. However #527 shows that there are legitimate Sympa functions such as unauthenticated archive views that invokeconfirm_actionas part of a GET request (i.e. the "I am not a spammer" click-through challenge for archives).This simple patch removes
confirm_actionfrom the%require_csrftokenlist. That allowsconfirm_actionto be invoked during GET requests, allowing unauthenticated archive views and other GET based confirmed actions to work as expected.Thankfully, the input validation in
Sympa::WWW::Session::confirm_action()acts against CSRF on its own, so we are still covered there. Theconfirmsubmission must be the very next click in the user's Sympa session, otherwise the pending action is cancelled. Furthermore the action arguments must match a recorded hash before the action can proceed.