Obfuscate cookie #248
Closed
Obfuscate cookie #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eval doesn't make sense to me for calling chmod function. I doubt it will crash in normal situations and also you need to check if the chmod was successful anyway. |
|
I just copy/paste'd the code above which does the chown. What would you suggest instead ? |
|
Copy/paste from where? |
|
From _save_binary_cache in src/lib/Conf.pm, just above the lines I've added. |
|
As discussed on irc meeting, this PR is closed. #250 will survive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #243, currently untested.