Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smalls addons for nginx config #77

Closed

Conversation

dcaillibaud
Copy link

Adding some fastcgi parameter to nginx config (and a link to wwsympa.service sample) for spawn-fcgi

@ikedas
Copy link
Member

ikedas commented Jan 21, 2021

As of 6.2.56, wwsympa became splitting URI by itself: See sympa-community/sympa#879 for details. That's why description about split_path_info was removed from example: It was moved to the note below.

As you wrote, CSS path may be required. I'll check it.

Thanks for inputs!

@dcaillibaud
Copy link
Author

Sorry, I didn't see theses notes (I'm still in 6.2.40 with debian buster and these lines are required, as note says).
I don't know if you can exclude the second commit from this PR, to keep the link added in the first commit.

If not I let you close the PR without merge, sorry for the noise.

@racke
Copy link
Contributor

racke commented Jan 21, 2021

The CSS part is only needed for Debian installations.

@dcaillibaud dcaillibaud changed the title Improve nginx conf Smalls addons for nginx config Jan 21, 2021
@ikedas
Copy link
Member

ikedas commented Jan 22, 2021

Hi @dcaillibaud ,

As you wrote, CSS path may be required. I'll check it.

$CSSDIR and $PICTURESDIR were subdirectories of $STATICDIR by default, on version prior to 6.2.26. However recently they are vary by environments (check the links of three). For purpose of example, I think all of these three would be better to appear in description.


BTW, to include your changes, could you please include addition of your name to /AUTHORS.md file into this PR? It is required by the license applied to this documentation (CC-BY-SA 4.0).

@@ -73,7 +73,7 @@ Note:
1. Register WWSympa FastCGI service.

Put ``wwsympa.service`` file into Systemd system directory
(such as ``/usr/lib/systemd/system``).
(such as ``/usr/lib/systemd/system``, see [theses examples](configure-http-server-systemdsocket.md#install-wwsympa-fastcgi-service)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link points the file not using spawn-fcgi.

# needed for debian buster
location /css-sympa {
alias /var/lib/sympa/css;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed description will be added by PR #89.

@ikedas ikedas closed this in #89 Dec 16, 2021
@ikedas
Copy link
Member

ikedas commented Dec 16, 2021

Hi @dcaillibaud , thanks for proposal of improvements. I included most of them into my PR and merged it. If you noticed anything, please submit changes again.

Thank you for input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants