Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cibuildwheel install #388

Closed
wants to merge 2 commits into from
Closed

Fix cibuildwheel install #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcd0674
Fix cibuildwheel install
aaron-skydio Apr 24, 2024
f060d2d
Update build_wheels.yml
aaron-skydio Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .github/scripts/mac_install_gmp.sh
View file
Open in desktop

This file was deleted.

36 changes: 17 additions & 19 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,64 +26,62 @@ jobs:
path: dist/*

build-macos:
runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os.runner }}
strategy:
fail-fast: false
matrix:
os: [macos-latest]
os:
- runner: macos-13
arch: x86_64
- runner: macos-latest
arch: arm64
python-version: [cp38, cp39, cp310, cp311, cp312]
arch: [x86_64, arm64]

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Install cibuildwheel
run: python3 -m pip install cibuildwheel==2.16.5

- name: Build wheels
run: python3 -m cibuildwheel --output-dir wheelhouse
uses: pypa/cibuildwheel@v2.17.0
env:
CIBW_BUILD: ${{ matrix.python-version }}-*
CIBW_ARCHS_MACOS: ${{ matrix.arch }}
CIBW_ARCHS_MACOS: ${{ matrix.os.arch }}
CIBW_BUILD_FRONTEND: build
GMP_ROOT: /Users/runner/work/${{ github.event.repository.name }}/${{ github.event.repository.name }}/arm-homebrew/opt/gmp
CIBW_BEFORE_BUILD: ./.github/scripts/mac_install_gmp.sh
# For arm64; for x86, it's at /usr/local but cmake finds that ok already
GMP_ROOT: /opt/homebrew
CIBW_BEFORE_BUILD: brew install gmp
CIBW_ENVIRONMENT: SYMFORCE_REWRITE_LOCAL_DEPENDENCIES=True

- name: Upload wheels
uses: actions/upload-artifact@v4
with:
name: symforce-wheels-macos-${{ matrix.python-version }}-${{ matrix.arch }}
name: symforce-wheels-${{ matrix.os.arch }}-${{ matrix.python-version }}
path: wheelhouse/*.whl

build-linux:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: [cp38, cp39, cp310, cp311, cp312]
arch: [x86_64]

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Install cibuildwheel
run: python3 -m pip install cibuildwheel==2.16.5

- name: Build wheels
run: python3 -m cibuildwheel --output-dir wheelhouse
uses: pypa/cibuildwheel@v2.17.0
env:
CIBW_BUILD: ${{ matrix.python-version }}-manylinux_${{ matrix.arch }}
CIBW_BUILD: ${{ matrix.python-version }}-manylinux_x86_64
CIBW_BUILD_FRONTEND: build
CIBW_BEFORE_BUILD: yum install -y gmp-devel git
CIBW_ENVIRONMENT: SYMFORCE_REWRITE_LOCAL_DEPENDENCIES=True

- name: Upload Wheels
uses: actions/upload-artifact@v4
with:
name: symforce-wheels-linux-${{ matrix.python-version }}
name: symforce-wheels-${{ matrix.os }}-${{ matrix.python-version }}
path: wheelhouse/*.whl

merge-wheel-artifacts:
Expand Down
Loading