Sync templates, var/cache mount, node 22, session clean #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Jul 26, 2024
| - type: has_composer_package | ||
| value: symfony/flex | ||
| - type: has_composer_package | ||
| value: symfonycorp/platformsh-meta |
There was a problem hiding this comment.
this was the only significant diff with 30-symfony-flex.yaml, yet we don't use this meta anymore (there is no recipe attached to it)
nicolas-grekas
commented
Jul 30, 2024
| @@ -47,7 +48,7 @@ template: | | |||
| passthru: "/{{.FrontController}}" | |||
|
|
|||
| mounts: | |||
| "/var": { source: storage, source_path: var } | |||
| "/var/cache": { source: instance, source_path: var/cache } | |||
There was a problem hiding this comment.
For thoughts: var/cache/prod/pools contains parts that would be better in a storage (app pools) and others which are better in instance (system pools).
We might check how to make a cleaner separation in Symfony itself.
There was a problem hiding this comment.
PR updated
fabpot
reviewed
Aug 1, 2024
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
love
branch
2 times, most recently
from
0107841 to
680beca
Compare
nicolas-grekas
changed the title
|
Updated to use composer audit |
nicolas-grekas
changed the title
|
Updated with a cron task to clean expired php sessions and set |
nicolas-grekas
force-pushed
the
love
branch
2 times, most recently
from
0511734 to
cd6c4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.