Forward to list on missing object during deletion #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm 👍 for this, an Exception is too harsh in this case. |
| @@ -70,6 +70,7 @@ action.object.delete: | |||
| confirm: Etes-vous sur de vouloir supprimer cet élement? | |||
| success: L'élément sélectionné a été supprimé. | |||
| error: L'élément sélectionné ne peut pas être supprimé. | |||
| notfound: Element ne peut pas être supprimé car il est déjà supprimé. | |||
There was a problem hiding this comment.
French one: Suppression impossible : l'élément est inconnu
|
2 comments, otherwise : 👍 |
bobvandevijver
added
ready for merge
and removed
awaiting feedback
ready to review
labels
|
👍 good for me |
bobvandevijver
added a commit
that referenced
this pull request
Mar 15, 2016
Forward to list on missing object during deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a object is not found during deletion (for example, when clicking the confirm button twice on the confirm page), you get an Exception which is too general: Object could not be removed.
This PR introduces an automatic forward, which creates a notification that it could not be removed as it already was removed.
Also added some tweaks in parts of the code to make it more consistent.