Make clean-webpack-plugin configurable #87
Comments
weaverryan
added a commit
that referenced
this issue
Jul 25, 2017
This PR was squashed before being merged into the master branch (closes #99). Discussion ---------- Refactor plugin configuration Extract encore built in plugin configuration logic into plugin utils. First step toward allowing to be able to configure plugins through options and have more modular integration for plugins inside encore. From now on only public API with proper options is needed, for most cases. This changes are internals and tries to improve plugin architecture inside encore. Please take a look on it and feedback are welcome :). So far I see improvements for several issues: * #2 - Point .2 ...for plugins we should do the same as for loaders, from point of view of module split (utilities). * #63 - Better (more modular) integration of the plugin as well its configuration. * #65 - Same as #63 * #79 - Now it should be possible to pass options and/or check for flags to apply plugin or not. * #87 - Some small steps to make clean plugin more configurable. Public API still need to be changed though. thanks in advance. Commits ------- 65adfdc Refactor plugin configuration
weaverryan
added a commit
that referenced
this issue
Sep 14, 2017
This PR was squashed before being merged into the master branch (closes #152). Discussion ---------- Add various methods to configure default plugins This PR adds some methods to configure default plugins (closes #148, closes #87 and closes #15): * `Encore.configureDefinePlugin(callback)` * `Encore.configureExtractTextPlugin(callback)` * `Encore.configureFriendlyErrorsPlugin(callback)` * `Encore.configureLoaderOptionsPlugin(callback)` * `Encore.configureUglifyJsPlugin(callback)` Other changes: * Allows the `clean-webpack-plugin` to be configured using `Encore.cleanupOutputBeforeBuild(paths, callback)` * Fixed a small mistake in the `Encore.configureManifestPlugin()` jsdoc * Reorganized flags/callbacks in the constructor of `webpack.config.js` since it was starting to be a bit hard to read. I'm not sure about the way I splitted things though, let me know what you think about it. * Renamed `common-chunks.js` to `commons-chunks.js` since the name of the plugin is `CommonsChunkPlugin` @weaverryan: Not directly related but while doing all of that I noticed that `sassOptions` uses snake-case whereas I used camel-case in #144 for `enablePreactPreset()` and in #115 for `configureRuntimeEnvironment()`, should we do something about that? ***Edit 1:** Added `Encore.configureCleanWebpackPlugin()`* ***Edit 2:** Removed `Encore.configureCleanWebpackPlugin()` to use `Encore.cleanupOutputBeforeBuild(paths, callback)` arguments instead* Commits ------- 286787a Minor text changes f72614b Remove configureCleanWebpackPlugin and use cleanupOutputBeforeBuild arguments instead 90c8565 Add various methods to configure default plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From a tweet!
https://twitter.com/DevCircus/status/884574052127518720
The text was updated successfully, but these errors were encountered: