[HttpClient][Mailer] Revert "Let curl handle transfer encoding", use HTTP/1.1 for Mailgun #57569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HTTP/1.1 for Mailgun
nicolas-grekas
force-pushed
the
fix-hc-chunked
branch
from
7c84f9c
to
efc93cd
Compare
This was referenced Jun 28, 2024
Merged
Merged
Merged
Merged
|
I'm having the same issue with the MailgunApiTransport.php, the fix is the same as the MailgunHttpTransport.php, adding |
fabpot
added a commit
that referenced
this pull request
Jul 2, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Mailer] force HTTP 1.1 for Mailgun API requests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #57544, Fix #57569 (comment) | License | MIT Commits ------- 0bf9e72 force HTTP 1.1 for Mailgun API requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #54517 and fixes #54491 by forcing HTTP/1.1 when talking to Mailgun
The issue that #54517 tries to fix shouldn't happen since curl 7.51, which dates back from 2016 (curl/curl@d4c5a91). If you experience it, try upgrading.
The previous code worked fine for years but the new one generated reports a few weeks after its release so I'd feel more confident reverting.