[PhpUnitBridge] Fixed PHPunit 9.5 compatibility #39331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
wouterj
force-pushed
the
issue-39329/phpunit-9.5
branch
from
ae8f296 to
1bff367
Compare
wouterj
force-pushed
the
issue-39329/phpunit-9.5
branch
from
1bff367 to
4d3e321
Compare
derrabus
reviewed
Dec 5, 2020
derrabus
changed the title
wouterj
force-pushed
the
issue-39329/phpunit-9.5
branch
from
4d3e321 to
5134de5
Compare
derrabus
approved these changes
Dec 5, 2020
fabpot
approved these changes
Dec 5, 2020
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Dec 5, 2020
…nents without tests (derrabus) This PR was merged into the 5.1 branch. Discussion ---------- [Notifier] Remove PHPUnit configuration files from components without tests | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follows #39331 by @wouterj. PHPUnit 9.5 fails if we look for tests in directories that do not exist. This is very reasonable behavior, imho. However, we do have some bridges in the Notifier component that don't provide any tests. Running PHPUnit on those bridges is pointless, which is why I'd like to remove the PHPUnit configuration from them. We can re-add the files as soon as we add tests. #SymfonyHackday Commits ------- 710340d Remove PHPUnit configuration files from components without tests.
derrabus
added a commit
that referenced
this pull request
Dec 5, 2020
This PR was merged into the 5.2 branch. Discussion ---------- [Notifier] Fix tests with PHPUnit 9.5 | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follow-up to #39331, #39335. #SymfonyHackday Commits ------- cb66c52 [Notifier] Fix tests with PHPUnit 9.5.
This was referenced Dec 18, 2020
Merged
Merged
Merged
keradus
added a commit
to PHP-CS-Fixer/PHP-CS-Fixer
that referenced
this pull request
Jan 9, 2021
This PR was merged into the 2.17 branch. Discussion ---------- DX: unblock PHPUnit 9.5 fixed on SF: symfony/symfony#39331 Commits ------- 0080b6c DX: unblock PHPUnit 9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this works 🍀
#SymfonyHackday