Remove choices as values in 3.0 #6459
Conversation
|
Well, it still exists (otherwise it would be a BC break). Only the default value changed in 3.0. It is deprecated as of Symfony 3.1. |
| @@ -19,7 +19,6 @@ To use this field, you must specify *either* ``choices`` or ``choice_loader`` op | |||
| | | - `choice_name`_ | | |||
| | | - `choice_translation_domain`_ | | |||
| | | - `choice_value`_ | | |||
| | | - `choices_as_values`_ | | |||
There was a problem hiding this comment.
It is deprecated as of 3.1, not removed :)
|
Technically it is not deprecated in 3.0, but I agree with Ryan to remove it from the as it does not support setting it to anything else than |
|
@HeahDude IIRC we always removed the description of features in the version they got deprecated (but here it doesn't make sense to document it imo). |
|
There were many issues on the repo and and questions on stack, although it is recommended to upgrade to 2.8 before upgrading to 3.0, not everyone does that 😢. I vote (without hard feeling) to keep it documented at the strict minimum by removing the "before/after" stuff but keeping a notice for the legacy reason of the default value. What do you think ? |
|
Now that I've read the discussion here, I think we should keep the option, but change the description to describe that it's not used anymore, and was something that helped you upgrade. Then, if people see this option in their code and look in the docs for it, they'll see the description. |
|
Okay, then let's keep the option and update the description instead. |
weaverryan
force-pushed
the
remove_choices_as_values
branch
from
0494fa2 to
51ee6f4
Compare
Well, actually keeping a short description, so people kind find a description of it if they see it in their project.
weaverryan
force-pushed
the
remove_choices_as_values
branch
from
51ee6f4 to
3d4ae1e
Compare
This PR was merged into the 3.0 branch. Discussion ---------- Remove choices as values in 3.0 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 3.0+ | Fixed tickets | n/a I think we must have just forgotten to remove this option! Commits ------- 3d4ae1e Removing all instances of choices_as_values in 3.0
|
Nice! Thanks! |
|
@weaverryan any idea why the status is "needs work" here ? |
|
@HeahDude because we didn't update the label to "finished" before merging. |
I think we must have just forgotten to remove this option!