[WCM] Document constraint validator alias optional #6055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mx-Glitter
changed the title
This was referenced Dec 20, 2015
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #6256). Discussion ---------- Fixed code example The new subscriber must be called after the default listener. The default sets the locale as ````php $locale = $request->attributes->get('_locale'); $request->setLocale($locale); ```` which overwrites any local set before it. Commits ------- 50bca94 Fixed code example
This PR was merged into the 2.3 branch. Discussion ---------- Rewrite EventDispatcher introduction | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - The event dispatcher docs were a bit old. I discovered it talked about bundles (while it's the components section). While reviewing the article, I've also removed some redundant things (creating special sub event classes was mentioned many times). I've also tried to reword things a bit and introduce new (more commonly used) concepts for events. Commits ------- e148cb4 Rewrite EventDispatcher introduction
…tion article (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Doctrine] some tweaks to the Doctrine registration article Commits ------- 999e783 some tweaks to the Doctrine registration article
| Q | A | --------------- | ---- | Doc fix? | yes | New docs? | no | Applies to | all
This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Bundles]fix yaml syntax | Q | A | --------------- | ---- | Doc fix? | yes | New docs? | no | Applies to | all Commits ------- d25a312 fix yaml syntax
This PR was merged into the 2.3 branch. Discussion ---------- mention routing from the database | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #2186, relates to #5709 if we merge #6020, we might want to put this as subsection of the extending_routing section Commits ------- c458431 mention routing from the database
…xt Generating Absolute URLs
…rface::ABSOLUTE_URI (eriwin) This PR was merged into the 2.3 branch. Discussion ---------- [Book] [Routing] Fix third param true to UrlGeneratorInterface::ABSOLUTE_URI | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | symfony/symfony#16991 This was forgotten in #6009 Commits ------- ec53faa Updated third param true to UrlGeneratorInterface::ABSOLUTE_URl in text Generating Absolute URLs
…er-denis) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #6278). Discussion ---------- [HttpFoundation] Fix typo for ParameterBag getters [HttpFoundation] Fix typo for max number of arguments for ParameterBag getters | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.7 | Fixed tickets | ~ Commits ------- 9a06dab [HttpFoundation] Fix typo for ParameterBag getters
Wrong closing tag for "container" tag in first XML services definition
I'm proposing this change after spending an hour trying to work out why my Repository class wasn't loading. Thanks to `ysor123` on IRC, we diagnosed the problem was the XML mapping files generated when reverse engineering my database, which I hadn't deleted. This is obliquely referred to at http://symfony.com/doc/current/book/doctrine.html#add-mapping-information: > A bundle can accept only one metadata definition format. For example, it's not possible to mix YAML metadata definitions with annotated PHP entity class definitions. It'd be great to clarify this for future readers.
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6251). Discussion ---------- To use annotations, files must be removed | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | Tested on 3.0 | Fixed tickets | N/A I'm proposing this change after spending an hour trying to work out why my Repository class wasn't loading. Thanks to `ysor123` on IRC, we diagnosed the problem was the XML mapping files generated when reverse engineering my database, which I hadn't deleted. This is obliquely referred to at http://symfony.com/doc/current/book/doctrine.html#add-mapping-information: > A bundle can accept only one metadata definition format. For example, it's not possible to mix YAML metadata definitions with annotated PHP entity class definitions. It'd be great to clarify this for future readers. Commits ------- 06de6c0 Updated per xabbuh's comment 6a526bf To use annotations, files must be removed
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Feb 23, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17074). Discussion ---------- Fix constraint validator alias being required | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16805 | License | MIT | Doc PR | symfony/symfony-docs#6055 This is my first contribution, so everything might not be in perfect order. Follow-up of #16841 on the right branch. Commits ------- 5136c30 Fix constraint validator alias being required
|
Closed in favor of #6300 on the right branch. |
weaverryan
added a commit
that referenced
this pull request
Apr 26, 2016
This PR was merged into the 2.3 branch. Discussion ---------- Document constraint validator alias optional | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no (symfony/symfony#17074) | Applies to | 2.3 | Fixed tickets | Same as #6055 but on the 2.3 branch as the relevant Symfony PR symfony/symfony#17074 was merged on 2.3. Commits ------- 873ede0 Document constraint validator alias optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #5952 but on master branch.