fix YAML syntax highlighting #5750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
changed the title
|
👍 |
|
I don't see any differences between symfony.com and the platform.sh build, but 👍 anyway it makes sense. |
|
I don't understand this change. I think we always use the double quotes for YAML strings. |
|
@wouterj @javiereguiluz You have to look at the |
|
@javiereguiluz double quotes means escape sequences in Yaml. So |
|
@wouterj thanks for the explanation. I understand it now :) Would it make sense to change all double quotes by single quotes then? |
xabbuh
added a commit
that referenced
this pull request
Oct 3, 2015
This PR was merged into the 2.3 branch. Discussion ---------- fix YAML syntax highlighting | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #5684 In YAML, double quoted strings can contain escape sequences. Thus, we would have to escape the backslash if we wanted to use them instead of single quotes (see the Platform.sh build to spot the difference now). Commits ------- 818d734 fix YAML syntax highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In YAML, double quoted strings can contain escape sequences. Thus, we would have to escape the backslash if we wanted to use them instead of single quotes (see the Platform.sh build to spot the difference now).