Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributing] [Standards] Added entry for Yoda conditions #5402

Closed
wants to merge 1 commit into from
Closed

[Contributing] [Standards] Added entry for Yoda conditions #5402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contributing/code/standards.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ Structure

* Place unary operators (``!``, ``--``, ...) adjacent to the affected variable;

* Use `Yoda conditions`_ when checking a variable against an expression to avoid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comment: #5402 (comment)

Is contributors are agree with it of course.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @soullivaneuh, I'd like to hear more thoughts on this.

an accidental assignment inside the condition statement;

* Add a comma after each array item in a multi-line array, even after the
last one;

Expand Down Expand Up @@ -186,3 +189,4 @@ License
.. _`PSR-1`: http://www.php-fig.org/psr/psr-1/
.. _`PSR-2`: http://www.php-fig.org/psr/psr-2/
.. _`PSR-4`: http://www.php-fig.org/psr/psr-4/
.. _`Yoda conditions`: https://en.wikipedia.org/wiki/Yoda_conditions