-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new cookbook about file uploading #5375
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ Controller | |
|
||
error_pages | ||
service | ||
upload_file |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,177 @@ | ||
.. index:: | ||
single: Controller; Upload; File | ||
|
||
How to Upload Files | ||
=================== | ||
|
||
.. note:: | ||
|
||
Instead of handling file uploading yourself, you may consider using the | ||
`VichUploaderBundle`_ community bundle. This bundle provides all the common | ||
operations (such as file renaming, saving and deleting) and it's tightly | ||
integrated with Doctrine ORM, MongoDB ODM, PHPCR ODM and Propel. | ||
|
||
Imagine that you have a ``Product`` entity in your application and you want to | ||
add a PDF brochure for each product. To do so, add a new property called ``brochure`` | ||
in the ``Product`` entity:: | ||
|
||
// src/AppBundle/Entity/Product.php | ||
namespace AppBundle\Entity; | ||
|
||
use Doctrine\ORM\Mapping as ORM; | ||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class Product | ||
{ | ||
// ... | ||
|
||
/** | ||
* @ORM\Column(type="string") | ||
* | ||
* @Assert\NotBlank(message="Please, upload the product brochure as a PDF file.") | ||
* @Assert\File(mimeTypes={ "application/pdf" }) | ||
*/ | ||
private $brochure; | ||
|
||
public function getBrochure() | ||
{ | ||
return $this->brochure; | ||
} | ||
|
||
public function setBrochure($brochure) | ||
{ | ||
$this->brochure = $brochure; | ||
|
||
return $this; | ||
} | ||
} | ||
|
||
Note that the type of the ``brochure`` column is ``string`` instead of ``binary`` | ||
or ``blob`` because it just stores the PDF file name instead of the file contents. | ||
|
||
Then, add a new ``brochure`` field to the form that manage the ``Product`` entity:: | ||
|
||
// src/AppBundle/Form/ProductType.php | ||
namespace AppBundle\Form; | ||
|
||
use Symfony\Component\Form\AbstractType; | ||
use Symfony\Component\Form\FormBuilderInterface; | ||
use Symfony\Component\OptionsResolver\OptionsResolver; | ||
|
||
class ProductType extends AbstractType | ||
{ | ||
public function buildForm(FormBuilderInterface $builder, array $options) | ||
{ | ||
$builder | ||
// ... | ||
->add('brochure', 'file', array('label' => 'Brochure (PDF file)')) | ||
// ... | ||
; | ||
} | ||
|
||
public function configureOptions(OptionsResolver $resolver) | ||
{ | ||
$resolver->setDefaults(array( | ||
'data_class' => 'AppBundle\Entity\Product', | ||
)); | ||
} | ||
|
||
public function getName() | ||
{ | ||
return 'product'; | ||
} | ||
} | ||
|
||
Now, update the template that renders the form to display the new ``brochure`` | ||
field (the exact template code to add depends on the method used by your application | ||
to :doc:`customize form rendering </cookbook/form/form_customization>`): | ||
|
||
.. code-block:: html+jinja | ||
|
||
{# app/Resources/views/product/new.html.twig #} | ||
<h1>Adding a new product</h1> | ||
|
||
{{ form_start() }} | ||
{# ... #} | ||
|
||
{{ form_row(form.brochure) }} | ||
{{ form_end() }} | ||
|
||
Finally, you need to update the code of the controller that handles the form:: | ||
|
||
// src/AppBundle/Controller/ProductController.php | ||
namespace AppBundle\ProductController; | ||
|
||
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route; | ||
use Symfony\Bundle\FrameworkBundle\Controller\Controller; | ||
use Symfony\Component\HttpFoundation\Request; | ||
use AppBundle\Entity\Product; | ||
use AppBundle\Form\ProductType; | ||
|
||
class ProductController extends Controller | ||
{ | ||
/** | ||
* @Route("/product/new", name="app_product_new") | ||
*/ | ||
public function newAction(Request $request) | ||
{ | ||
$product = new Product(); | ||
$form = $this->createForm(new ProductType(), $product); | ||
$form->handleRequest($request); | ||
|
||
if ($form->isValid()) { | ||
// $file stores the uploaded PDF file | ||
/** @var Symfony\Component\HttpFoundation\File\UploadedFile $file */ | ||
$file = $product->getBrochure() | ||
|
||
// Generate a unique name for the file before saving it | ||
$fileName = md5(uniqid()).'.'.$file->guessExtension(); | ||
|
||
// Move the file to the directory where brochures are stored | ||
$brochuresDir = $this->container->getParameter('kernel.root_dir').'/../web/uploads/brochures'; | ||
$file->move($brochuresDir, $fileName); | ||
|
||
// Update the 'brochure' property to store the PDF file name | ||
// instead of its contents | ||
$product->setBrochure($filename); | ||
|
||
// persist the $product variable or any other work... | ||
|
||
return $this->redirect($this->generateUrl('app_product_list')); | ||
} | ||
|
||
return $this->render('product/new.html.twig', array( | ||
'form' => $form->createView() | ||
)); | ||
} | ||
} | ||
|
||
There are some important things to consider in the code of the above controller: | ||
|
||
#. When the form is uploaded, the ``brochure`` property contains the whole PDF | ||
file contents. Since this property stores just the file name, you must set | ||
its new value before persisting the changes of the entity. | ||
#. In Symfony applications, uploaded files are objects of the | ||
:class:`Symfony\\Component\\HttpFoundation\\File\\UploadedFile` class, which | ||
provides methods for the most common operations when dealing with uploaded files. | ||
#. A well-known security best practice is to never trust the input provided by | ||
users. This also applies to the files uploaded by your visitors. The ``Uploaded`` | ||
class provides methods to get the original file extension (:method:`Symfony\\Component\\HttpFoundation\\File\\UploadedFile::getExtension()`), | ||
the original file size (:method:`Symfony\\Component\\HttpFoundation\\File\\UploadedFile::getSize()`) | ||
and the original file name (:method:`Symfony\\Component\\HttpFoundation\\File\\UploadedFile::getClientOriginalName()`). | ||
However, they are considered *not safe* because a malicious user could tamper | ||
that information. That's why it's always better to generate a unique name and | ||
use the :method:`Symfony\\Component\\HttpFoundation\\File\\UploadedFile::guessExtension()` | ||
method to let Symfony guess the right extension according to the file MIME type. | ||
#. The ``UploadedFile`` class also provides a :method:`Symfony\\Component\\HttpFoundation\\File\\UploadedFile::move()` | ||
method to store the file in its intended directory. Defining this directory | ||
path as an application configuration option is considered a good practice that | ||
simplifies the code: ``$this->container->getParameter('brochures_dir')``. | ||
|
||
You can now use the following code to link to the PDF brochure of an product: | ||
|
||
.. code-block:: html+jinja | ||
|
||
<a href="{{ asset('uploads/brochures' ~ product.brochure) }}">View brochure (PDF)</a> | ||
|
||
.. _`VichUploaderBundle`: https://github.com/dustin10/VichUploaderBundle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding this above?
/** @var Symfony\...\UploadedFile $file */