-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a paragraph about updating multiple packages during an update #5336
Conversation
Note: Meant to be merged into 2.3 |
Isn't this quite strange? Composer update should trigger a partial update afaik, which means it should also update twig/twig if a newer version is required. Are we sure Symfony has the correct version constraint for twig? |
Yeah, that sounds weird. @weaverryan Do you remember what required you to use a newer Twig version than the one you had installed? |
In my case I didn't have problems with Twig but with some Doctrine dependencies. I know that you won't agree but I believe that when you perform a "brutal update" (like updating Symfony version) you should always execute |
@xabbuh: yes, symfony/symfony required a newer version of twig/twig than I had installed. I have no twig/twig in my composer.json. So I also thought that Composer would be smart enough to update twig, even though it's not an arg in my update command, but that's not the case. So what should we do? The error - and getting it working- is confusing. But the brutal update (with no args) really means people need to have great version constraints. @javiereguiluz - was your error with doctrine/common? I'm wondering because maybe this is solved (or mostly solved) if you update symfony/symfony + whatever libs it depends on directly. Thanks! |
Maybe @Seldaek can give us some clues if this behaviour is the expected one ( From a usage point of view, the current behaviour seems rather strange/hard to use. |
@weaverryan in my case it was a problem with Doctrine fixtures ... but it only happened in one project. I'm afraid that there are so many different constraints configurations, that for a lot of developers doing |
@weaverryan @javiereguiluz I'm curious. Could you please show how your |
Composer used to be smart enough as you say and update dependencies as well when you did a partial update, but then for some packages you end up updating half the project, so it's not so great. Either you have to whitelist all the deps yourself or you can use |
Thanks for the information @Seldaek. So I think we should change the instructions to |
I just updated this with |
👍 |
$ composer update symfony/symfony --with-dependencies | ||
|
||
This updates ``symfony/symfony`` and *all* packages that it depends on, | ||
will include several other packages. By using tight version constraints in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second part of the first sentences doesn't sound quite right. Maybe something like "which will include several other packages. [...]" is better?
…ing an update (weaverryan) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5336). Discussion ---------- Adding a paragraph about updating multiple packages during an update | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Hi guys! For my 2.7 upgrade, I needed to run `composer update symfony/symfony twig/twig`. I'm trying to include a note to help other people. I'd appreciate opinions on wording :). Thanks! Commits ------- bb0acd0 fixing bad wording 8a30d14 using --with-dependencies 7a28919 Adding a paragraph about updating multiple packages at once during an upgrade
Hi guys!
For my 2.7 upgrade, I needed to run
composer update symfony/symfony twig/twig
. I'm trying to include a note to help other people. I'd appreciate opinions on wording :).Thanks!