Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about the Symfony Demo application #5164

Merged
merged 1 commit into from
May 3, 2015

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

@@ -95,3 +103,4 @@ practices**. The reasons for not doing it are various:
your tests or adding features that provide real value to the end users.

.. _`Fabien Potencier`: https://connect.sensiolabs.com/profile/fabpot
.. _`download and install`: http://symfony.com/download
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we link to the installation chapter from the book instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in this case we are talking about downloading and installing the installer. The symfony.com/download page is the place where this information is more concisely explained. The installation chapter is more verbose because it explains everything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed that the download page got some more detailed instructions.

@wouterj
Copy link
Member

wouterj commented May 2, 2015

Fixes #4476

@weaverryan
Copy link
Member

Yes! Congrats and thanks for all your hard work on this Javier! The demo app has become something entirely bigger and more interesting than the tiny thing it was last year. Keep up the nice work :)

@weaverryan weaverryan merged commit 6383a9b into symfony:2.3 May 3, 2015
weaverryan added a commit that referenced this pull request May 3, 2015
…aviereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Added information about the Symfony Demo application

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | -

Commits
-------

6383a9b Added information about the Symfony Demo application
@javiereguiluz javiereguiluz deleted the add_demo_app branch January 3, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants