Fixed loadUserByUsername method coding errors #5149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linasm83
commented
Apr 5, 2015
linasm83
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.6, 2.7, 3.0 |
| Fixed tickets |
|
Oew, I didn't need to think a lot about the correctness of this PR :) Thanks Linas! I've merged it into the 2.3 branch, as the issues exists there as well. That's why you'll see a close status on GitHub instead of merged. Anyway, it's included in the docs now. |
wouterj
added a commit
that referenced
this pull request
Apr 7, 2015
…icius) This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5149). Discussion ---------- Fixed loadUserByUsername method coding errors | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6, 2.7, 3.0 | Fixed tickets | Commits ------- 3a7acfb Fixed loadUserByUsername function coding errors
|
Will be a lesson for me to check a bit different next time, in 2.4 and 2.5 code was different and correct, didn't thought at it will have the same issue in 2.3 :) |
|
The 2.4 and 2.5 versions are no longer maintained (we only maintain versions that haven't reached end of life) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.