[Book][Testing] bump required PHPUnit version #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 2, 2015
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| @@ -17,7 +17,7 @@ it has its own excellent `documentation`_. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Symfony works with PHPUnit 3.5.11 or later, though version 3.6.4 is | |||
| Symfony works with PHPUnit 3.5.11 or later, though version 4.2 is | |||
There was a problem hiding this comment.
Should we really still talk about PHPUnit 3.5.11 here?
There was a problem hiding this comment.
Actually, I'm not sure we can still run our testsuite on 3.5.11. I'm actually quite sure we started using 3.6+ features a long time ago, and we probably even use some newer features in a few place. So the requirement version should be bumped.
And the recommendation should be to use the latest stable version IMO (because this is what we actually use on Travis and on our development boxes, and so this is what actually works for sure)
There was a problem hiding this comment.
IIRC the testsuite uses atLeastOnce() which requires 4.2.
xabbuh
force-pushed
the
update-required-phpunit-version
branch
from
3dd5877 to
c5d4ce1
Compare
|
Thanks! |
weaverryan
added a commit
that referenced
this pull request
Jan 16, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [Book][Testing] bump required PHPUnit version | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- c5d4ce1 bump required PHPUnit version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.