Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doctrine.rst #4461

Closed
wants to merge 2 commits into from
Closed

Update doctrine.rst #4461

wants to merge 2 commits into from

Conversation

guiguiboy
Copy link
Contributor

fixed typo

xabbuh
xabbuh reviewed Nov 13, 2014
View reviewed changes
book/doctrine.rst
@@ -747,7 +747,7 @@ normal ``Query`` object, which can be used to get the result of the query.
(``:price`` in the example above) as it prevents SQL injection attacks.

The ``getResult()`` method returns an array of results. To get only one
result, you can use ``getSingleResult()`` (which throws exception there is no
result, you can use ``getSingleResult()`` (which throws exception if there is no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should actually read "which throws an exception if there [...]". What do you think?

@guiguiboy
Update doctrine.rst
39fd2a0 
fixed typo (bis)
@guiguiboy
Copy link
Contributor Author

You're right. I've changed it.

@xabbuh
Copy link
Member

xabbuh commented Nov 13, 2014

👍 Great, I like it.

@wouterj
Copy link
Member

wouterj commented Nov 14, 2014

Thanks @guiguiboy. Good catch, great fix and quick response!

wouterj added a commit that referenced this pull request Nov 14, 2014
@wouterj
minor #4461 Update doctrine.rst (guiguiboy)
0d91cc5 
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4461).

Discussion
----------

Update doctrine.rst

fixed typo

Commits
-------

cb0865d Update doctrine.rst
@wouterj wouterj closed this Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guiguiboy @xabbuh @wouterj