Update security.rst #3636
Update security.rst #3636
Conversation
I'm not a native speaker but I think that it sounds better by adding that before the word `start`.
| @@ -20,7 +20,7 @@ perform a certain action. | |||
| .. image:: /images/book/security_authentication_authorization.png | |||
| :align: center | |||
|
|
|||
| Since the best way to learn is to see an example, start by securing your | |||
| Since the best way to learn is to see an example, let's start by securing your | |||
There was a problem hiding this comment.
Our standard is to avoid the first person perspective.
There was a problem hiding this comment.
I agree with both of you, we should avoid the first person, but the current sentence really needs a first person perspective here. So we have to rewrite the complete sentence.
There was a problem hiding this comment.
ha, I'm also struggling a bit here :).
There was a problem hiding this comment.
Since the best way to learn is to see an example, just imagine that you want to secure your application with HTTP Basic authentication.
There was a problem hiding this comment.
ping @nomack84 - do you want to make the change suggested by @xabbuh?
Thanks!
There was a problem hiding this comment.
@weaverryan I'll close this PR because I did it with the edit featured of GitHub and I'll create a new one with this change by @xabbuh
|
Well, I think that's not necessary so I'll do it in this one in a moment. |
|
@weaverryan It's done. |
|
Great, thanks Mario! |
I'm not a native speaker but I think that it reads better now.