Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Bundles] improve explanation of code block for bundle removal #3413

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cookbook/bundles/remove.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ starting a project, but you'll probably want to eventually remove it.

To disconnect the bundle from the framework, you should remove the bundle from
the ``AppKernel::registerBundles()`` method. The bundle is normally found in
the ``$bundles`` array but the AcmeDemoBundle is only registered in a
development environment and you can find him in the if statement after::
the ``$bundles`` array but the AcmeDemoBundle is only registered in the
development environment and you can find it inside the if statement below::

// app/AppKernel.php

Expand Down Expand Up @@ -96,8 +96,8 @@ rely on the bundle you are about to remove.
.. tip::

If one bundle relies on another, in most it means that it uses some services
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, we have a typo here as well (in most cases it means). Could you possibly add that to your PR (even though it wasn't your mistake)?

Thanks :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i did not see this, I am in Salt Lake City, Utah now so this escaped me else I would have fixed it, sorry @weaverryan

from the bundle. Searching for a ``acme_demo`` string may help you spot
them.
from the bundle. Searching for the bundle alias string may help you spot
them (e.g. ``acme_demo`` for bundles depending on AcmeDemoBundle).

.. tip::

Expand Down