Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AssetMapper] Add info about troubleshooting assets loading with Panther. #20316

Merged

Conversation

WedgeSama
Copy link
Contributor

Add more info on Panther tests due to PHP built in server.

When a requested URI is not a .php file nor a directory, the built in server will try to directly server the corresponding "file". But if the file does not exist AND must be handle by Symfony app, the built in server just return a 404.

  • Can happen with any requested URI that look like a non .php file
  • Case can happen with AssetMapper.

see
symfony/panther#630
https://symfonycasts.com/screencast/last-stack/testing#debugging-by-opening-the-browser
https://www.php.net/manual/en/features.commandline.webserver.php

@carsonbot carsonbot added this to the 6.4 milestone Oct 10, 2024
@WedgeSama WedgeSama force-pushed the panther-troubleshooting-assets-404 branch 3 times, most recently from 0bf480b to 30bc4c9 Compare October 12, 2024 05:59
testing/end_to_end.rst Outdated Show resolved Hide resolved
testing/end_to_end.rst Outdated Show resolved Hide resolved
testing/end_to_end.rst Outdated Show resolved Hide resolved
testing/end_to_end.rst Outdated Show resolved Hide resolved
testing/end_to_end.rst Outdated Show resolved Hide resolved
@WedgeSama WedgeSama force-pushed the panther-troubleshooting-assets-404 branch 3 times, most recently from 6a8cc6d to 3f91a7a Compare October 14, 2024 08:17
- Can happen with any requested uri that look like a non `.php` file
- Case can happen with AssetMapper.
@WedgeSama WedgeSama force-pushed the panther-troubleshooting-assets-404 branch from 3f91a7a to f2a68b5 Compare October 14, 2024 08:19
@carsonbot carsonbot changed the title Add info about troubleshooting assets loading with Panther. [AssetMapper] Add info about troubleshooting assets loading with Panther. Oct 14, 2024
@javiereguiluz javiereguiluz merged commit eb71ee4 into symfony:6.4 Oct 14, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Benjamin, thanks a lot for this contribution (thanks also to Matthieu for the review too).

While merging we did some changes: 78e0a19

It looks like a lot of changes 😢 but don't worry. They are just minor cosmetic changes and it rearranges some contents. The core of your contribution was kept. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants