Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the server_version option of DoctrineBundle for DBAL #4597

Closed
stof opened this issue Dec 5, 2014 · 2 comments
Closed

Document the server_version option of DoctrineBundle for DBAL #4597

stof opened this issue Dec 5, 2014 · 2 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Doctrine good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@stof
Copy link
Member

stof commented Dec 5, 2014

DoctrineBundle 1.3 (compatible with Symfony 2.3+) added the possibility to configure the server_version option of DBAL 2.5.
This option needs to be documented because Doctrine ORM unfortunately triggers the retrieval of the database platform too early currently, and for drivers needing to change the platform based on the server version, this triggers an early connection to the DB in case it relies on guessing.
This is likely to concern lots of people upgrading to the new DBAL 2.5 given that MySQL is one of the platforms needing version switches

See doctrine/DoctrineBundle#351 (comment) for a config example.
@wouterj
Copy link
Member

wouterj commented Dec 6, 2014

Hmm, so if I'm correct, there is a BC break in the Doctrine bundle which causes problems for many people (all people using MySQL for instance)?

@wouterj wouterj added Doctrine actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Dec 6, 2014
@stof
Copy link
Member Author

stof commented Dec 16, 2014

There is no BC break in DoctrineBundle. There is a change in DBAL, and because of the way the ORM uses DBAL, the version guessing is triggered even in case we don't actually need it, which requires connecting to the DB if the version is not explicitly configured.

But in any case, the new setting should be documented

@javiereguiluz javiereguiluz mentioned this issue Feb 19, 2015
Merged
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Feb 19, 2015
weaverryan added a commit that referenced this issue Mar 14, 2015
@weaverryan
feature #5017 Added a note about the server_version DBAL option (javi…
1dbed80 
…ereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Added a note about the server_version DBAL option

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3+
| Fixed tickets | #4597

Some comments:

  * This is probably a temporary fix because DoctrineBundle will hopefully fix this problem soon
  * DBAL options are not explained, so I added this explanation as a `note`
  * If you agree with this, please merge this PR soon because people are having problems with this new option

Commits
-------

470f713 Added a note about the server_version DBAL option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Doctrine good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @stof @wouterj