Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack-encore-bundle] Disable build notifications by default #1353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[webpack-encore-bundle] Disable build notifications by default #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions symfony/webpack-encore-bundle/2.0/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
"core-js": "^3.38.0",
"regenerator-runtime": "^0.13.9",
"webpack": "^5.74.0",
"webpack-cli": "^5.1.0",
"webpack-notifier": "^1.15.0"
"webpack-cli": "^5.1.0"
},
"license": "UNLICENSED",
"private": true,
Expand Down
3 changes: 2 additions & 1 deletion symfony/webpack-encore-bundle/2.0/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ Encore
* https://symfony.com/doc/current/frontend.html#adding-more-features
*/
.cleanupOutputBeforeBuild()
.enableBuildNotifications()
// Displays build status system notifications to the user
// .enableBuildNotifications()
Comment on lines +40 to +41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two newlines for visual separations with the rest, and that's good to me :)

Suggested change
// Displays build status system notifications to the user
// .enableBuildNotifications()
// Displays build status system notifications to the user
// .enableBuildNotifications()

.enableSourceMaps(!Encore.isProduction())
// enables hashed filenames (e.g. app.abc123.css)
.enableVersioning(Encore.isProduction())
Expand Down
Loading