Fix setValue on checkbox and select fields if they are multiple #526
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Robert! |
robertfausk
deleted the
fix_setValue_on_checkbox_and_select_fields_if_multiple
branch
|
@dunglas I just realized that this PR is not upstream merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ChoiceFormField::setValueis only able to add new values if the field isselectorchoice.This only-adding behavior:
ChoiceFormField::setValueofsymfony-dom-crawlerwhich resets the value of the field by the given value.This PR unsets all previous values from given field before the given value is set.
PS: Do I have do take any action to get this PR into the
mainbranch? 🙃