moving MonologBundle docs to bundle repo #124
Conversation
Added installation chapter.
snoek09
changed the title
|
looks good 👍 |
snoek09
changed the title
|
👍 |
| ------------------------- | ||
|
|
||
| Then, enable the bundle by adding the following line in the ``app/AppKernel.php`` | ||
| file of your project: |
There was a problem hiding this comment.
by adding the following line
Which line? The code example has more than a single line.
Would be better to assume the user knows what to look for in the code example and say "Then enable the bundle by adding it to a list of registered bundles in the app/AppKernel.php file of your project:"
There was a problem hiding this comment.
That would be more clear. I would suggest changing this in the Installation Instructions template as well: http://symfony.com/doc/current/cookbook/bundles/best_practices.html#installation-instructions
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ composer require symfony/monolog-bundle "~2.7" |
There was a problem hiding this comment.
I'd prefer to not specify the version only composer require symfony/monolog-bundle is enough.
There was a problem hiding this comment.
It isn't, as it means the 2.7 docs would make people install 3.0 (if that version is released) as it would just take the latest stable version if you don't specify a version. This could lead to much confusion.
|
is there anything left here ? |
|
Good to merge imho as @jakzal's comment has been addressed. |
stof
changed the title
moving MonologBundle docs to bundle repo
…ons (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Bundles] clarify bundle installation instructions | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | symfony/monolog-bundle#124 (comment) Commits ------- 5a33e0e clarify bundle installation instructions
Added installation chapter.
Easy picks on bundle side from symfony/symfony-docs#4983