[HttpClient] fix adding query string to relative URLs with scoped cli…

…ents
symfony · May 14, 2021 · 30b901a · 30b901a
1 parent 7bac9c0
commit 30b901a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/ScopingHttpClient.php b/ScopingHttpClient.php
@@ -71,11 +71,12 @@ public function request(string $method, string $url, array $options = []): Respo
                 throw $e;
             }
 
-            $options = self::mergeDefaultOptions($options, $this->defaultOptionsByRegexp[$this->defaultRegexp], true);
+            $defaultOptions = $this->defaultOptionsByRegexp[$this->defaultRegexp];
+            $options = self::mergeDefaultOptions($options, $defaultOptions, true);
             if (\is_string($options['base_uri'] ?? null)) {
                 $options['base_uri'] = self::parseUrl($options['base_uri']);
             }
-            $url = implode('', self::resolveUrl($url, $options['base_uri'] ?? null));
+            $url = implode('', self::resolveUrl($url, $options['base_uri'] ?? null, $defaultOptions['query'] ?? []));
         }
 
         foreach ($this->defaultOptionsByRegexp as $regexp => $defaultOptions) {

diff --git a/Tests/ScopingHttpClientTest.php b/Tests/ScopingHttpClientTest.php
@@ -30,9 +30,9 @@ public function testRelativeUrl()
     public function testRelativeUrlWithDefaultRegexp()
     {
         $mockClient = new MockHttpClient();
-        $client = new ScopingHttpClient($mockClient, ['.*' => ['base_uri' => 'http://example.com']], '.*');
+        $client = new ScopingHttpClient($mockClient, ['.*' => ['base_uri' => 'http://example.com', 'query' => ['a' => 'b']]], '.*');
 
-        $this->assertSame('http://example.com/foo', $client->request('GET', '/foo')->getInfo('url'));
+        $this->assertSame('http://example.com/foo?f=g&a=b', $client->request('GET', '/foo?f=g')->getInfo('url'));
     }
 
     /**