Skip to content

Commit

Permalink
Merge branch '5.3' into 5.4
Browse files Browse the repository at this point in the history
* 5.3:
  Remove more dynamic properties
  [Serializer] fix support for unset properties on PHP < 7.4
  • Loading branch information
nicolas-grekas committed Nov 17, 2021
2 parents 0154236 + 7c5c562 commit 23591dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions Internal/AmpBody.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
class AmpBody implements RequestBody, InputStream
{
private $body;
private $info;
private $onProgress;
private $offset = 0;
private $length = -1;
Expand Down
2 changes: 1 addition & 1 deletion RetryableHttpClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function request(string $method, string $url, array $options = []): Respo
if ('' !== $context->getInfo('primary_ip')) {
$shouldRetry = $this->strategy->shouldRetry($context, null, $exception);
if (null === $shouldRetry) {
throw new \LogicException(sprintf('The "%s::shouldRetry()" method must not return null when called with an exception.', \get_class($this->decider)));
throw new \LogicException(sprintf('The "%s::shouldRetry()" method must not return null when called with an exception.', \get_class($this->strategy)));
}

if (false === $shouldRetry) {
Expand Down

0 comments on commit 23591dc

Please sign in to comment.